This change is kinda backwards. We should take version and optionally add the v prefix.

semantically the github release urls are derived from the git tag, which don't necessarily map cleanly from the version. In #338301 the idea of a tag input and output for fetchFromGitHub was brought up which I fully support, but in the meanwhile I believe this is the easiest treewide to consistently enforce.

I don't really understand. How is what you propose any simpler, clearer, or more reliable than using the version like so:

changelog = "https://codeberg.org/forgejo/forgejo/releases/tag/v${version}";

In my opinion your version is more complex, and needlessly spends compute cycles modifying strings when we already have said string in version. This is all so you don't have to put the v in front of version in the URL?

If an upstream is so far off from our versioning that you can't just re-use version, then treat that as the odd-ball that it is. There's no reason to apply premature optimization and complexity everywhere else because of edge cases.

Okay, have it your way. Note now that the review requires you to view the whole file. I assume someone will in the future come along and revert the change back to src.rev not knowing better.

I left forgejo with lib.removePrefix since rev is provided as an input to callPackage

I left forgejo with lib.removePrefix since rev is provided as an input to callPackage

version is used and required in multiple places in this internal abstraction (generic.nix) of Forgejo.
Please change it to v${version}, just like you did with all the other packages.

Thanks :)

Thanks for pointing that out 👍